Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce DrawingContextHelper.RenderAsync method #13128

Merged
merged 1 commit into from Oct 4, 2023
Merged

Conversation

maxkatz6
Copy link
Member

@maxkatz6 maxkatz6 commented Oct 4, 2023

What does the pull request do?

Introduce DrawingContextHelper.RenderAsync method to render Avalonia Visuals into a Skia Canvas.

This method is async as ImmediateRenderer is going to be replaced with an asynchronous composition renderer for both this method and RenderTargetBitmap in the future.

Fixed issues

Fixes #13127

@avaloniaui-team
Copy link
Contributor

You can test this PR using the following package version. 11.0.999-cibuild0040429-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@maxkatz6 maxkatz6 added this pull request to the merge queue Oct 4, 2023
Merged via the queue into master with commit 3986206 Oct 4, 2023
6 checks passed
@maxkatz6 maxkatz6 deleted the render-async-skia branch October 4, 2023 09:23
@maxkatz6 maxkatz6 added the backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch label Nov 5, 2023
maxkatz6 added a commit that referenced this pull request Dec 5, 2023
#Conflicts:
#	src/Skia/Avalonia.Skia/Helpers/DrawingContextHelper.cs
@maxkatz6 maxkatz6 added backported-11.0.x and removed backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch labels Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return possibility to render avalonia controls into a SKCanvas
3 participants