[Text] Fix hit testing issues #13155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter-freeze-on-inline
Fix GetPreviousCaretCharacterHit Fix WrapWithOverflow for not text runs
maxkatz6
approved these changes
Oct 9, 2023
|
You can test this PR using the following package version. |
|
You can test this PR using the following package version. |
Gillibald
added
the
backport-candidate-11.0.x
maxkatz6
pushed a commit
that referenced
this pull request
Dec 5, 2023
* Repro for Line_Formatting_For_Oversized_Embedded_Runs_Does_Not_Freeze * Repro for Line_With_IncrementalTab_Should_Return_Correct_Backspace_Position * Fix GetBackspaceCaretCharacterHit Fix GetPreviousCaretCharacterHit Fix WrapWithOverflow for not text runs * Fix custom font manager * Move DejaVuSans to a different location to prevent using it as a fallback --------- Co-authored-by: Nikita Tsukanov <keks9n@gmail.com>
maxkatz6
added
backported-11.0.x
and removed
backport-candidate-11.0.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR adjusts the text formatting pipeline to be more in line with the WPF implementation.
GetBackspaceCaretCharacterHitnow reports a hit position that fulfills grapheme boundaries instead of glyph cluster boundaries. That way ligatures can be deleted partially.GetPreviousCaretCharacterHitis now always producing a hit on the left edge of some glyph. Therefore the result should always have a TrailingLength of zero in the middle of some text run.WrapWithOverflowpreviously skipped runs entirely if not a single run fits into available space. This was adjusted so if nothing can be wrapped all layouted runs are added to the line.What is the current behavior?
What is the updated/expected behavior with this PR?
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues