New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Gestures): Allow using some Gestures
events in Xaml
#13232
Merged
maxkatz6
merged 11 commits into
AvaloniaUI:master
from
workgroupengineering:features/Core/Gestures/Add-Some-Event-Handlers
Oct 17, 2023
Merged
feat(Gestures): Allow using some Gestures
events in Xaml
#13232
maxkatz6
merged 11 commits into
AvaloniaUI:master
from
workgroupengineering:features/Core/Gestures/Add-Some-Event-Handlers
Oct 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are some event names that I think should be changed. I will open an issue with the proposed changes. Here there is a proposal of events rename. |
You can test this PR using the following package version. |
maxkatz6
approved these changes
Oct 17, 2023
workgroupengineering
deleted the
features/Core/Gestures/Add-Some-Event-Handlers
branch
October 18, 2023 03:23
maxkatz6
added
the
backport-candidate-11.0.x
Consider this PR for backporting to 11.0 branch
label
Nov 5, 2023
maxkatz6
pushed a commit
that referenced
this pull request
Dec 5, 2023
* feat(Gestures): Adds HoldingEvent handlers * feat(Gestures): Adds PinchEvent handlers * feat(Gestures): Adds PinchEndedEvent handlers * feat(Gestures): Adds PullGestureEvent handlers * feat(Gestures): Adds PullGestureEndedEvent handlers * feat(Gestures): Adds PointerTouchPadGestureMagnifyEvent handlers * feat(Gestures): Adds PointerTouchPadGestureRotateEvent handlers * feat(Gestures): Adds PointerTouchPadGestureSwipeEvent handlers * feat(Gestures): Adds ScrollGestureEvent handlers * feat(Gestures): Adds ScrollGestureEndedEvent handlers * feat(Gestures): Adds ScrollGestureInertiaStartingEvent handlers
maxkatz6
added
backported-11.0.x
and removed
backport-candidate-11.0.x
Consider this PR for backporting to 11.0 branch
labels
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Allow using some
Gestures
events in XamlWhat is the current behavior?
If using Gesture in Xaml compiler throw
AVLN: 0004: XamlX.XamlParseException: Unable to resolve suitable regular or attached property Pinch
What is the updated/expected behavior with this PR?
Compile
How was the solution implemented (if it's not obvious)?
XamlC
to identify that it is an attached event, looks for the presence of a method namedAdd<EventName>Handler
example for thePinchEvent
eventAddPinchHandler
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues
Fixes #13231