Fix OpenGlControlBase: Ensure _updateQueued is set to false when DoCleanup() is called #13260
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Ensure
_updateQueued
is set to false whenDoCleanup()
is called.Currently, when
OpenGlControlBase
is detached from the visual tree. MethodDoCleanup()
will get called immediately.However, in this method it doesn't set
_updateQueued
to false, which will fail the following check:OpenGlControlBase.cs
at Line #226:As the result, the OpenGlControl will never get any frame output after it re-attached to the visual tree.
What is the current behavior?
Now the cleanup method will ensure to set the
_updateQueud
to false inDoCleanup()
.What is the updated/expected behavior with this PR?
Now the control that using OpenGL will still work after the control is re-attached to the visual tree.