Fix TimePicker empty designator on 12 hour clock #13469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet-policy-service agree |
maxkatz6
approved these changes
Nov 12, 2023
maxkatz6
added
the
backport-candidate-11.0.x
maxkatz6
pushed a commit
that referenced
this pull request
Dec 5, 2023
* Test - On empty PM/AM designator on culture info the time picker should show AM/PM * On empty PM/AM designator on culture info the time picker should show AM/PM
maxkatz6
added
backported-11.0.x
and removed
backport-candidate-11.0.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR ensures that the PM/AM designator on the timepicker will be visible even if the current culture designators are empty.
As per documentation https://learn.microsoft.com/en-us/dotnet/api/system.globalization.datetimeformatinfo.amdesignator?view=net-7.0 , the designators could return an empty string.
What is the current behavior?
Currently, if the current culture designator is empty and the TimePicker property is set to 12 hour type, it will show empty boxes with no text.
What is the updated/expected behavior with this PR?
If the current culture info PM/AM designators are empty, take the PM/AM designator from the invariant culture.
Checklist