Fix overlapping items in VirtualizingStackPanel
#13765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ports the fix in AvaloniaUI/Avalonia.Controls.TreeDataGrid#229 to Avalonia. Fixes #12744
MrJul
added
the
backport-candidate-11.0.x
5 tasks
|
Awesome! Thank you very much! |
probably, yes. At least it's planned. Will be available in nightly and 11.1 for sure. So if you need this fix faster, try nightly for now. |
maxkatz6
pushed a commit
that referenced
this pull request
Dec 5, 2023
* Added failing test for #12744. * Inserting items makes the StartU unstable. This ports the fix in AvaloniaUI/Avalonia.Controls.TreeDataGrid#229 to Avalonia. Fixes #12744 #Conflicts: # tests/Avalonia.Controls.UnitTests/VirtualizingStackPanelTests.cs
maxkatz6
added
backported-11.0.x
and removed
backport-candidate-11.0.x
Is there some kind of release schedule? |
As you can see, this PR has the There also seems to be a new git tag for 11.0.6, so it may be released soon. The 11.0.6 packages appear in the nightly feed, if you want to test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
As described in #12744, sometimes items in a virtualized
ItemsControlwould start overlapping.The reason is simple: inserting items before the current viewport should cause
RealizedStackElementsto markStartUas unstable because we don't now actually know the start U position any more (we haven't measured the inserted item).This is a port of a fix for
TreeDataGridbut this time I actually wrote a simple unit test which tests the source of the problem (although a unit test for the actual visible effect of this bug is a lot more difficult, and I've still not managed to repro in a unit test).Fixed issues
Fixes #12744
Part of #13736