Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Expander header icon flip when collapsing or expanding canceled #13780

Merged
merged 1 commit into from Dec 5, 2023

Conversation

memorydream
Copy link
Contributor

@memorydream memorydream commented Nov 30, 2023

What does the pull request do?

fix expander header icon

What is the current behavior?

header icon flip when Collapsing or Expanding canceled

What is the updated/expected behavior with this PR?

header icon dont flip

Fixed issues

Fix #13768

@memorydream
Copy link
Contributor Author

@dotnet-policy-service agree

@memorydream memorydream changed the title fix: Expander style fix: Expander header icon flip when collapsing or expanding canceled Nov 30, 2023
@robloo
Copy link
Contributor

robloo commented Dec 2, 2023

Tested and this looks good to me. Thanks for fixing this!

The failing tests are unrelated to these changes. If you merge in latest master branch though it will restart the tests and they might pass this time.

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.1.999-cibuild0042578-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@zii-dmg
Copy link
Contributor

zii-dmg commented Dec 3, 2023

Tag is for user data, you should not change it in default styles.

@memorydream
Copy link
Contributor Author

Tag is for user data, you should not change it in default styles.

Please view linked issue , this hack is already used in SplitButton , just follow it

@robloo
Copy link
Contributor

robloo commented Dec 3, 2023

Also note that Tag is not accessible for user use in this case. The header ToggleButton is part of the control template.

@maxkatz6 maxkatz6 added this pull request to the merge queue Dec 5, 2023
@maxkatz6 maxkatz6 removed this pull request from the merge queue due to a manual request Dec 5, 2023
@maxkatz6 maxkatz6 merged commit 208e540 into AvaloniaUI:master Dec 5, 2023
6 checks passed
@maxkatz6 maxkatz6 added the backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch label Dec 5, 2023
@maxkatz6 maxkatz6 added backported-11.0.x and removed backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch labels Dec 5, 2023
@memorydream memorydream deleted the fix/expander-style branch December 5, 2023 10:34
robloo added a commit to robloo/FluentAvalonia that referenced this pull request Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When canceling Collapsing event of Expander its icon still flips
5 participants