Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Avalonia.Browser.props #13820

Merged
merged 1 commit into from Dec 4, 2023
Merged

Conversation

maxkatz6
Copy link
Member

@maxkatz6 maxkatz6 commented Dec 4, 2023

See https://github.com/dotnet/runtime/blob/88b5e3d4b77dd8238331ade1b31ac8ddc62f22f7/src/mono/wasm/build/WasmApp.targets#L85-L90

This PR helps us to avoid an annoying breaking change in .NET 8, which would break Avalonia apps otherwise.

@maxkatz6 maxkatz6 added the backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch label Dec 4, 2023
Copy link
Contributor

@Takoooooo Takoooooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,thanks!

@maxkatz6 maxkatz6 merged commit 5e31b36 into master Dec 4, 2023
5 of 7 checks passed
@maxkatz6 maxkatz6 deleted the browser-avoid-breaking-change branch December 4, 2023 10:24
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.1.999-cibuild0042620-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

maxkatz6 added a commit that referenced this pull request Dec 5, 2023
@maxkatz6 maxkatz6 added backported-11.0.x and removed backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch labels Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants