Improving TextBox behaviour on Ctrl+Backspace down event #14138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
exGensImpl
changed the title
|
You can test this PR using the following package version. |
Gillibald
approved these changes
Jan 9, 2024
Gillibald
added
the
backport-candidate-11.0.x
maxkatz6
added
backported-11.0.x
and removed
backport-candidate-11.0.x
maxkatz6
pushed a commit
that referenced
this pull request
Jan 17, 2024
* Test: TextBox Ctrl+Back caret position * Fixed: TextBox Ctrl+Back caret position * Test: TextBox Ctrl+Back remove double whitespace * Fixed: TextBox Ctrl+Back remove double whitespace * Test: TextBox Ctrl+Back undo return caret position * Fixed: TextBox Ctrl+Back undo return caret position
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR improves
TextBoxbehaviour onCtrl+Backspacegesture down eventWhat is the current behavior?
TextBoxdoesn't change the caret position accordingly to the text shiftTextBoxdoesn't remove a whitespace before the deleting word, which results in a double space at its place after deletionTextBoxdoesn't reset the caret position to the place before deletionWhat is the updated/expected behavior with this PR?
TextBoxsets the caret position to the start of the deleted wordTextBoxremoves a whitespace before the deleting wordTextBoxresets the caret position to the place before deletionChecklist