Make Classic ApplicationLifetime API a bit more reliable #14267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxkatz6
added
the
backport-candidate-11.0.x
maxkatz6
force-pushed
the
lifetime-api-fixes
branch
from
38c9e96
to
e32fdb1
Compare
|
You can test this PR using the following package version. |
Gillibald
approved these changes
Jan 19, 2024
|
You can test this PR using the following package version. |
maxkatz6
added a commit
that referenced
this pull request
Feb 8, 2024
* Add StartWithClassicDesktopLifetime overload with a lifetime builder * Disallow changing Application.ApplicationLifetime after setup was completed * Avoid static dependency on a singleton lifetime * Introduce SetupWithClassicDesktopLifetime method * Move more logic from Start method to Setup * Add docs * Avoid public API changes * Fix tests * Repalce locator usage with `.UseLifetimeOverride` --------- Co-authored-by: Benedikt Stebner <Gillibald@users.noreply.github.com>
maxkatz6
added
backported-11.0.x
and removed
backport-candidate-11.0.x
|
@maxkatz6 regarding this:
How can I get the (obsolete) |
|
@danipen added this documentation page: https://docs.avaloniaui.net/docs/concepts/services/activatable-lifetime#handling-uri-activation |
|
Got it! Thank you so much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
I recommend reviewing this PR commit by commit, as there are multiple independent changes.
s_activeLifetime. Instead lifetime should subscribe on window events after it was set-up, and not when it was constructed. And also - unsubscribe from these events.Breaking changes
Application.ApplicationLifetime cannot be set after application was started. It will throw a runtime error.
Since this never was supported nor properly handled, I wouldn't consider it a blocker for backporting.
Obsoletions / Deprecations
Application.UrlsOpened is obsolete - use IActivatableApplicationLifetime.