Removes hard-coded Grid.RowSpan and Grid.ColumnSpan from FluentTheme … #14460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in Data grid - based on #12301
maxkatz6
approved these changes
Feb 3, 2024
maxkatz6
added
the
backport-candidate-11.0.x
|
@KrzysztofDusko can you do me a favor and also check if SimpleTheme has the same issue? Thanks for your contribution 🙏 |
|
@timunie SimpleTheme in my opinion is OK. |
maxkatz6
added
backported-11.0.x
and removed
backport-candidate-11.0.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…in Data grid - based on #12301
What does the pull request do?
Removes hard-coded Grid.RowSpan and Grid.ColumnSpan from FluentTheme
What is the current behavior?
it's hard to override this values
What is the updated/expected behavior with this PR?
Properties can be overridden easly.
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues
Fixes #14458