fix macos crash at startup by not parsing all app arguments into uris. #14494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxkatz6
approved these changes
Feb 5, 2024
maxkatz6
reviewed
Feb 5, 2024
| @@ -13,12 +13,21 @@ internal class AvaloniaNativeApplicationPlatform : NativeCallbackBase, IAvnAppli | |||
| void IAvnApplicationEvents.FilesOpened(IAvnStringArray urls) | |||
| { | |||
There was a problem hiding this comment.
This method is never really executed anymore?
There was a problem hiding this comment.
still executed to maintain legacy behaviour, but it wont call the new uri api codepath from here.
|
You can test this PR using the following package version. |
danwalmsley
added
the
backport-candidate-11.0.x
|
You can test this PR using the following package version. |
maxkatz6
pushed a commit
that referenced
this pull request
Feb 8, 2024
maxkatz6
added
backported-11.0.x
and removed
backport-candidate-11.0.x
nift4
added a commit
to nift4/GalaxyBudsClient
that referenced
this pull request
Feb 10, 2024
We need this fix for macOS: AvaloniaUI/Avalonia#14494 because when reopening an already-open app from finder, it calls openURLs which crashes in 11.0.7 but Linux/X11 requires 11.0.7 or unreleased version for working menus so do just use the proper CI build instead of waiting for Avalonia to make a new release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was caused due to the "FilesOpened" callback being unexpectedly raised for all command line arguments.
The recent PR #14106 implemented a Uri protocol raised event, where the data was parsed into a uri.
Its not possible to do this for all arguments.
This PR does the following:
Separate the macOS backend callbacks
(void)application:(NSApplication *)sender openFilesand(void)application:(NSApplication *)application openURLsinto 2 separate callbacks in our backend (previously they were the same)Continue raising the legacy
RaiseUrlsOpenedcodepath from the FilesOpened (as has worked for many years), to not break previous behaviour.Only raise the new uri handling code from the
openURLSmacOS callback, and use Uri.TryCreate ().This fixes the bug and ensures the old behaviour.
Fixes #14411