Fix CompiledBinding with RelativeSource/ElementName but no Path #14514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And one passing test.
...without a path. Previously the `convertedNode` was being discarded if the binding node had no arguments or property value assignments. Fixes #14456
grokys
added
bug
backport-candidate-11.0.x
grokys
force-pushed
the
fixes/14456-compiledbinding-relativesource
branch
from
41641ab
to
3b81ffc
Compare
|
You can test this PR using the following package version. |
maxkatz6
approved these changes
Feb 6, 2024
maxkatz6
added
backported-11.0.x
and removed
backport-candidate-11.0.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
As described in #14456,
CompiledBindings were in some cases not respectingRelativeSourceandElementNamedespite this working with the "shorthand" syntax.The problem was that in
AvaloniaXamlIlBindingPathParser.TransformtheconvertedNodewas being discarded if the binding node had no arguments or property value assignments. Add in an extra case to make sure that doesn't happen.Fixed issues
Fixes #14456