Make integration tests catch issues with Icon Loading #14593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danwalmsley
added
backport-candidate-11.0.x
…ons will be tests.
danwalmsley
force-pushed
the
fixes/loading-icondata-crash
branch
from
7858c9a
to
5bad8b3
Compare
maxkatz6
approved these changes
Feb 14, 2024
|
You can test this PR using the following package version. |
|
You can test this PR using the following package version. |
maxkatz6
added
backported-11.0.x
and removed
backport-candidate-11.0.x
maxkatz6
added a commit
that referenced
this pull request
Feb 20, 2024
…ons will be tests. (#14593) Co-authored-by: Max Katz <maxkatz6@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
11.0.8 broke loading ico files using the api.
note failing test, and then passing with the PR that fixes the issue.
This screen shot was taken targeting release/11.0 (stable)
Retargetting for master (which was unaffected)... make sure its back ported.