You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that whatever is decided here also must be done to SplitButton. SplitButton was based on Button code in this area. (It doesn't inherit from Button since WinUI doesn't do that either. Although it was debated we left that like upstream at least for 11.0).
The reason will be displayed to describe this comment to others. Learn more.
These changes make sense.
If we want to define this as an expected behavior, it should also be unit tested (i.e., changing Command inside of CanExecute handler or something obscure like that).
* test: CommandParameter does not change between CanExecute and Execute
* feat: CommandParameter does not change between CanExecute and Execute
* test: update
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
workgroupengineering
force-pushed
the
fixes/Controls/ICommadSource_Implemetation
branch
2 times, most recently
from
maxkatz6
added
the
backport-candidate-11.1.x
What does the pull request do?
Ensure CanExecute and Execute consistence.
What is the current behavior?
The current implementation of ICommandSource does not guarantee that CanExecute and Execute occur on the same command.
What is the updated/expected behavior with this PR?
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues