-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump DBus stack take 2 #15685
base: master
Are you sure you want to change the base?
Bump DBus stack take 2 #15685
Conversation
- Use new Variant system
…-tmds-dbus-sourcegenerator
You can test this PR using the following package version. |
…-tmds-dbus-sourcegenerator
…-tmds-dbus-sourcegenerator
…-tmds-dbus-sourcegenerator # Conflicts: # src/Avalonia.FreeDesktop/DBusPlatformSettings.cs
@affederaffe since this PR has breaking changes, you need to run |
…into bump-tmds-dbus-sourcegenerator
Only the PropertyChanges type was made internal as it should be, it was a mistake to make it public at first. |
@affederaffe we still need to run the API validation regardless as it's a hard requirement for making stable builds at the moment |
What does the pull request do?
Bump Tmds.DBus.Protocol and Tmds.DBus.SourceGenerator.
This uses the "official" Variant system instead of the SourceGenerator provided one (which was removed).
Accept the explicit ignoration of the DBus spec and assume collapsed variants.
What is the current behavior?
What is the updated/expected behavior with this PR?
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
None
Fixed issues
#15655