Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump DBus stack take 2 #15685

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

affederaffe
Copy link
Contributor

@affederaffe affederaffe commented May 10, 2024

What does the pull request do?

Bump Tmds.DBus.Protocol and Tmds.DBus.SourceGenerator.
This uses the "official" Variant system instead of the SourceGenerator provided one (which was removed).
Accept the explicit ignoration of the DBus spec and assume collapsed variants.

What is the current behavior?

What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

Checklist

Breaking changes

Obsoletions / Deprecations

None

Fixed issues

#15655

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0048326-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@maxkatz6 maxkatz6 requested a review from jmacato May 11, 2024 02:45
@maxkatz6 maxkatz6 added os-linux backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch and removed backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch labels May 13, 2024
@maxkatz6
Copy link
Member

@affederaffe since this PR has breaking changes, you need to run nuke ValidateApiDiff command locally (nuke tool needs to be installed, alternatively, you can run _build project with the same command directly).
As it looks like, some autogenerated dbus files were made internal, as they should be.

@affederaffe
Copy link
Contributor Author

Only the PropertyChanges type was made internal as it should be, it was a mistake to make it public at first.
It is safe to make it internal as it is unusable by itself, all members that use this type (i.e. proxies with WatchPropertyChangedAsync) are already internal, so there cannot be any users of this api anyway.

@jmacato
Copy link
Member

jmacato commented Jul 21, 2024

@affederaffe we still need to run the API validation regardless as it's a hard requirement for making stable builds at the moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants