Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed NativeAOT on .NET 9 #15705

Merged
merged 2 commits into from
May 14, 2024
Merged

Fixed NativeAOT on .NET 9 #15705

merged 2 commits into from
May 14, 2024

Conversation

MrJul
Copy link
Member

@MrJul MrJul commented May 13, 2024

What does the pull request do?

This PR fixes NativeAOT compilation when targeting .NET 9.0.
See #15646 for details.

How was the solution implemented (if it's not obvious)?

dotnet/runtime#99732 means we don't need #14966 anymore, so that target is now skipped on .NET ≥ 9.0.

Note that TargetFrameworkVersion is checked, and not NETCoreSdkVersion.
The fixed code is in the Microsoft.DotNet.ILCompiler package which depends on the target framework, not the SDK.

Fixed issues

@MrJul MrJul added area-infrastructure Issues related to CI/tooling infrastructur backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch labels May 13, 2024
@kekekeks kekekeks enabled auto-merge May 13, 2024 16:24
@kekekeks kekekeks added this pull request to the merge queue May 13, 2024
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0048383-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks May 13, 2024
@jmacato jmacato enabled auto-merge May 14, 2024 01:50
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0048409-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@maxkatz6 maxkatz6 added the bug label May 14, 2024
@jmacato jmacato added this pull request to the merge queue May 14, 2024
Merged via the queue into AvaloniaUI:master with commit cfcc964 May 14, 2024
11 checks passed
@MrJul MrJul deleted the fix/nativeaot-net9 branch May 16, 2024 20:43
grokys pushed a commit that referenced this pull request Jun 3, 2024
Co-authored-by: Jumar Macato <16554748+jmacato@users.noreply.github.com>
@grokys grokys added backported-11.1.x and removed backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch labels Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Issues related to CI/tooling infrastructur backported-11.1.x bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish NativeAOT failed with .NET 9
6 participants