Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demonstrate binding Menu commands. #1893

Merged
merged 2 commits into from Sep 17, 2018
Merged

Demonstrate binding Menu commands. #1893

merged 2 commits into from Sep 17, 2018

Conversation

grokys
Copy link
Member

@grokys grokys commented Sep 12, 2018

Added a demonstration of how to bind commands in dynamically-created menus to ControlCatalog.

@grokys grokys requested a review from a team September 12, 2018 21:26
@jkoritzinsky
Copy link
Collaborator

Do we want to add this to BindingDemo as well/instead of ControlCatalog?

@grokys
Copy link
Member Author

grokys commented Sep 12, 2018

Not sure, it might make sense, though I think creating a dynamic menu fits with ControlCatalog and adding commands to it is kind of a natural part of that.

Copy link
Member

@danwalmsley danwalmsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danwalmsley danwalmsley merged commit a5016cd into master Sep 17, 2018
@jkoritzinsky jkoritzinsky deleted the demo/dynamic-menus branch September 17, 2018 20:07
@grokys grokys added this to the 0.7.0 milestone Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants