Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix color resource names #2023

Merged
merged 2 commits into from Oct 25, 2018
Merged

fix color resource names #2023

merged 2 commits into from Oct 25, 2018

Conversation

danwalmsley
Copy link
Member

Consider that you want to implement a DarkTheme

currently we have a light theme with resources named Light and Dark

This means in your dark theme, you would end up assigning colors like Black to a variable named Light and a color like White to a variable named Dark.

UWP take the approach of naming colors Low, Mid, High, etc.

This makes the same change.

@wieslawsoltes
Copy link
Contributor

wieslawsoltes commented Oct 25, 2018

To update wiki:

Breaking changes in 0.7 version release:

  • Renamed theme resource from ThemeBorderLightColor to ThemeBorderLowColor.
  • Renamed theme resource from ThemeControlLightColor to ThemeControlLowColor.
  • Renamed theme resource from ThemeForegroundLightColor to ThemeForegroundLowColor.
  • Renamed theme resource from ErrorLightColor to ErrorLowColor.
  • Renamed theme resource from ThemeBorderLightBrush to ThemeBorderLowBrush.
  • Renamed theme resource from ThemeControlLightBrush to ThemeControlLowBrush.
  • Renamed theme resource from ThemeForegroundLightBrush to ThemeForegroundLowBrush.
  • Renamed theme resource from ErrorLightBrush to ErrorLowBrush.
  • Renamed theme resource from ThemeBorderDarkColor to ThemeBorderHighColor.
  • Renamed theme resource from ThemeControlDarkColor to ThemeControlHighColor.
  • Renamed theme resource from ThemeControlHighlightDarkColor to ThemeControlHighlightHighColor.
  • Renamed theme resource from ThemeBorderDarkBrush to ThemeBorderHighBrush.
  • Renamed theme resource from ThemeControlDarkBrush to ThemeControlHighBrush.
  • Renamed theme resource from ThemeControlHighlightDarkBrush to ThemeControlHighlightHighBrush.

@wieslawsoltes wieslawsoltes merged commit be298e6 into master Oct 25, 2018
@wieslawsoltes wieslawsoltes deleted the fixes/resource-naming branch October 25, 2018 14:09
@grokys grokys modified the milestone: 0.7.0 Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants