-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Viewbox implementation #2066
Viewbox implementation #2066
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created a ViewBoxPage for the control catalog and compared it with the same page in WPF. The results don't look quite right.
WPF looks as I'd expect it to:
However, Avalonia doesn't look right:
Not quite sure what's causing the difference. Is this expected?
updated default of ClipToBounds to true (which i missed initially) to behave as wpf.
anyway made tiny modifications to example page and it look like it's working fine: ps: it look to me that somehow wpf Grid is processing rowdefinitions Auto with * logic, when all rows are Auto and making some smart stuff with stackpanel/grid measurements |
Yeah, I was wondering if the problem might be with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just pushed a quick fix to alphabetically order the pages in ControlCatalog, hope that's OK!
Add Viewbox and simplifies LayoutTransform control
we don't have Viewbox
Checklist: