Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes render demo with new tab control #2125

Merged
merged 2 commits into from Nov 22, 2018

Conversation

Gillibald
Copy link
Contributor

  • What does the pull request do?
    The render demo now runs properly with the new TabControl
  • What is the current behavior?
  • What is the updated/expected behavior with this PR?
  • How was the solution implemented (if it's not obvious)?

Copy link
Contributor

@Sorien Sorien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like there is wrong indent in SideBar.xaml...

@grokys
Copy link
Member

grokys commented Nov 22, 2018

@Sorien our XAML .editorconfig settings are actually set to use an indent of 4: we currently use a mix of the 2 and 4 in our XAML files but given that this change touched so much of the Sidebar.xml file I figured that updating it to follow our conventions was acceptable here.

We really should go through our xaml files and fix the indent (or change the indent 2 to and do the same).

@grokys grokys merged commit 6baa611 into AvaloniaUI:master Nov 22, 2018
@grokys grokys added this to the 0.8.0 milestone Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants