Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: add VirtualizingGridPanel #2143

Closed
wants to merge 3 commits into from

Conversation

ahopper
Copy link
Contributor

@ahopper ahopper commented Nov 28, 2018

  • What does the pull request do?
    Adds a VirtualizingGridPanel that displays as many fixed sized item as fit into the container and allows proper scrolling on a line by line basis
  • What is the current behavior?
    no such control, attempts to create virtualizingpanels without core changes can only scroll an item at a time rather than a line at a time.
  • How was the solution implemented (if it's not obvious)?

IVirtualizingPanel was extended to include a ScrollQuantum which is used by ItemVirtualizerSimple to scroll properly.
Whilst this works perfectly for the VirtualizingGridPanel and the existing VirtualizingStackPanel I'm not sure it is particularly future proof extension for other possible virtualizing panels hence the wip status.

Checklist:

@ahopper
Copy link
Contributor Author

ahopper commented Apr 3, 2019

I'm closing this as it complicates an already complex bit of code for very little general gain. Maybe the wpf source will throw up a better solution.

@ahopper ahopper closed this Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant