Tree view multiple selection support #2347
Conversation
| /// <summary> | ||
| /// Node search info. | ||
| /// </summary> | ||
| public readonly struct SearchInfo |
There was a problem hiding this comment.
Why encapsulate these two TreeViewItem references and the GetMatch method in a struct? I would seem to be that you could just pass them as parameters to the relevant methods.
| @@ -639,7 +639,7 @@ private static IEnumerable<object> GetRange(IEnumerable items, int first, int la | |||
| /// </summary> | |||
| /// <param name="items">The items collection.</param> | |||
| /// <param name="desired">The desired items.</param> | |||
| private static void SynchronizeItems(IList items, IEnumerable<object> desired) | |||
| internal static void SynchronizeItems(IList items, IEnumerable<object> desired) | |||
There was a problem hiding this comment.
Nit: now that this is internal, could you move it up above the private methods?
There was a problem hiding this comment.
I was not sure where to put it, do you follow any file layout guidelines in Avalonia?
There was a problem hiding this comment.
It's not a strict ordering, but I usually use the order public, protected, internal, private, i.e. from most public to least public.
I know there are many places where we don't follow that, mostly because of edits. However, if we can keep it tidy i'd prefer it and an internal modifier between private methods just sets my senses tingling ;)
There was a problem hiding this comment.
I see, at work I use the R# file layout that is automatically applied on their cleanup reformat. Makes life a bit easier when you don't have to think about it :)
There was a problem hiding this comment.
Yeah, I really wish there was a gofmt for csharp :/
|
@grokys Implemented your feedback. Let me know if you need something else from me. |
What does the pull request do?
Implements multiple selection behavior for
TreeViewusingSelectingItemsControlimplementation as a baseline.What is the current behavior?
TreeViewdoes not support multiple selection at all. Also operations like toggle are not supported, so it was impossible to deselect an item using Control modifier.What is the updated/expected behavior with this PR?
Enabled the multiple selection on
TreeViewPage, so user can now select multiple elements.How was the solution implemented (if it's not obvious)?
I couldn't really use
SelectingItemsControldue to index requirements (andTreeViewdoes not use contiguous item collection), so I had to port it to work for this case.I did not implement
AlwaysSelectedyet, can add in followup if needed. Also similar toSelectingItemsControlswitchingSelectionModeat runtime does not change current selection.Checklist
Breaking changes
It replaces
SelectedItemChangedevent withSelectionChangedevent, which uses the same event args, but semantically means that there could be multiple items that got selected/deselected.Fixed issues
cc: @grokys