Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #2544 #2879

Merged
merged 7 commits into from Sep 18, 2019
Merged

Fix for #2544 #2879

merged 7 commits into from Sep 18, 2019

Conversation

matthias-hoste
Copy link
Contributor

What does the pull request do?

It fixes a bug for apps with spaces in their name.

What is the current behavior?

The assembly name is currently not url decoded before trying to load it.

What is the updated/expected behavior with this PR?

It will correctly url decode it so it can load assemblies with spaces in their name.

Checklist

Breaking changes

Fixed issues

Fixes #2544

@danwalmsley danwalmsley added this to To do in 0.9 Release via automation Sep 9, 2019
@danwalmsley danwalmsley moved this from To do to In progress in 0.9 Release Sep 9, 2019
Copy link
Member

@jmacato jmacato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me

@jmacato jmacato merged commit bedb8d7 into AvaloniaUI:master Sep 18, 2019
0.9 Release automation moved this from In progress to Done Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
0.9 Release
  
Done
Development

Successfully merging this pull request may close these issues.

Avalonia Resource lookup fails when assembly has space in its name
3 participants