Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CTRL+Click to clear DataGridColumn sort #3618

Merged
merged 1 commit into from Feb 28, 2020
Merged

Add CTRL+Click to clear DataGridColumn sort #3618

merged 1 commit into from Feb 28, 2020

Conversation

Symbai
Copy link
Contributor

@Symbai Symbai commented Feb 27, 2020

What does the pull request do?

Adds CTRL+Click to clear DataGridColumn sort.

What is the current behavior?

It is currently not possible for the end user to clear sort directions after he/she clicked/sorted a column. This behavior is identical to WPF.

What is the updated/expected behavior with this PR?

User can clear the sort. This behavior is different to WPF but matching with for example DevExpress and other control libraries.

How was the solution implemented (if it's not obvious)?

Execute existing sort code only when CTRL is not pressed. There is already a keyboard input check for SHIFT key so in the end I only added one IF condition for CTRL. There was also some code factoring done by VS.

@grokys grokys merged commit 82526bc into AvaloniaUI:master Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants