Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button state update when CommandParameter changed #5772

Merged
merged 3 commits into from Apr 18, 2021
Merged

Button state update when CommandParameter changed #5772

merged 3 commits into from Apr 18, 2021

Conversation

reejk
Copy link
Contributor

@reejk reejk commented Apr 13, 2021

What does the pull request do?

Updates Button.IsEnabled after change Button.CommandParameter

What is the current behavior?

Button.CommandParameter changes doesn't affect IsEnabled

How was the solution implemented (if it's not obvious)?

Porting MenuItem code to Button

@dnfadmin
Copy link

dnfadmin commented Apr 13, 2021 •
edited

CLA assistant check
All CLA requirements met.

@reejk reejk marked this pull request as ready for review April 13, 2021 11:36
maxkatz6
maxkatz6 approved these changes Apr 18, 2021
View reviewed changes
Copy link
Member

@maxkatz6 maxkatz6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Looks good to me

@maxkatz6 maxkatz6 merged commit 24051ae into AvaloniaUI:master Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxkatz6 maxkatz6 maxkatz6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@reejk @dnfadmin @maxkatz6