Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup layout visualizer and improve UX. #5926

Merged
merged 3 commits into from May 17, 2021

Conversation

MarchingCube
Copy link
Contributor

@MarchingCube MarchingCube commented May 15, 2021

What does the pull request do?

Small UX improvements for dev tools. Uses new Viewbox functionality to avoid layout visualizer getting clipped plus a highlight for active layout section.

Also made sizing constraints a bit more obvious and fixed layout problems caused by lack of control size display rounding.

devtools-ux

Checklist

@MarchingCube
Copy link
Contributor Author

MarchingCube commented May 15, 2021

@Takoooooo
Copy link
Contributor

Also updated docs here: https://docs.avaloniaui.net/docs/getting-started/developer-tools

Hello, Dariusz! Just curious. Would it be possible to show the selector for the selected element in DevTools? I assume it may be super helpful

@MarchingCube
Copy link
Contributor Author

@Takoooooo Potentially yes - although it is tricky since there are usually multiple ways of creating a selector for the control. One could create a very long direct selector that includes every ancestor in the tree, or create a class only selector. On top of that there are templated controls that introduce own scopes and one has to figure - which selector should show (one inside the template, or from the root).

Copy link
Member

@maxkatz6 maxkatz6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarchingCube MarchingCube merged commit 9810e80 into AvaloniaUI:master May 17, 2021
danwalmsley pushed a commit that referenced this pull request May 19, 2021
Cleanup layout visualizer and improve UX.
@MarchingCube MarchingCube deleted the devtools-layout-ux branch May 19, 2021 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants