fix implementation of ScalingChanged property. #5948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
there were 2x implementations, 1x implicit, 1x explicit... :face-palm:
grokys
approved these changes
May 19, 2021
danwalmsley
pushed a commit
that referenced
this pull request
May 19, 2021
…ly-osx fix implementation of ScalingChanged property.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Dragging from a high dpi monitor to a low dpi monitor or vice versa would cause ui not to update scaling...
What is the current behavior?
What is the updated/expected behavior with this PR?
works correctly.
How was the solution implemented (if it's not obvious)?
erm... a bit embarrassing!
we had double implementation of interface property. probably a refactoring error.
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues