Fix devtools selection highlight requiring direct hover over the control #5949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rol type or name.
danwalmsley
approved these changes
May 19, 2021
danwalmsley
pushed a commit
that referenced
this pull request
May 19, 2021
Fix devtools selection highlight requiring direct hover over the control
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Fixes fairly annoying issue that requires hovering over the element name to see the bounds adorner.
What is the current behavior?
One has to zig zag through dev tools tree view to actually follow control bounds.
What is the updated/expected behavior with this PR?
Entire element area applies bounds adorner.
devtools-tree-highlight.mp4
How was the solution implemented (if it's not obvious)?
It depends on the default tree view item template to find a control that represents the header but excludes children.
We want to exclude children since pointer enter/leave events bubble and cause all sort of problems for the current implementation.
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues