Don't activate window when extending client area. #5989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danwalmsley
approved these changes
May 31, 2021
danwalmsley
pushed a commit
that referenced
this pull request
Jun 4, 2021
…endclientarea Don't activate window when extending client area.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Fixes the issue described in #5988:
Window.ShowActivated = falsedoesn't work withExtendClientAreaToDecorationsHint = true.When a window with
ExtendClientAreaToDecorationsHintis shown on win32,WindowImpl.ExtendClientAreais called which in turn calls the win32SetWindowPosAPI. HoweverSetWindowPosFlags.SWP_NOACTIVATEwasn't being passed to that function, causing the window to be activated regardless of theShowActivatedsetting.Pass
SetWindowPosFlags.SWP_NOACTIVATEtoSetWindowPoshere whetherShowActivatedis set or not: the window will be activated in the laterSetWindowPoscall if necessary.Fixed issues
Fixes #5988