Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting adorner bounds on init #6189

Closed
wants to merge 1 commit into from
Closed

Setting adorner bounds on init #6189

wants to merge 1 commit into from

Conversation

YohDeadfall
Copy link
Contributor

While an adorner subscribes for TransformedBounds changes an initial value isn't set. This PR fixes the issue by setting bounds before subscription.

grokys
grokys requested changes Jul 5, 2021
View reviewed changes
Copy link
Member

@grokys grokys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be necessary because GetObservable fires immediately on subscription with the current value of the property.

@YohDeadfall YohDeadfall closed this Jul 5, 2021
@YohDeadfall YohDeadfall deleted the set-bounds-on-init branch July 5, 2021 13:38
@YohDeadfall
Copy link
Contributor Author

The problem here is that both adorned and adornee controls participate in the same pass, and Arrange for the adornee uses a newer bounds than used for Measure. See #6242.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grokys grokys grokys requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@YohDeadfall @grokys