Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makes TextBox.UndoRedoState struct readonly #6228

Merged
merged 2 commits into from
Jul 10, 2021
Merged

Makes TextBox.UndoRedoState struct readonly #6228

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0864f3c
Makes TextBox.UndoRedoState struct readonly
MihaMarkic Jul 10, 2021
a63ea76
Merge branch 'master' into makes_readonly_struct
MarchingCube Jul 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Avalonia.Controls/TextBox.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ public class TextBox : TemplatedControl, UndoRedoHelper<TextBox.UndoRedoState>.I
(o, v) => o.UndoLimit = v,
unsetValue: -1);

struct UndoRedoState : IEquatable<UndoRedoState>
readonly struct UndoRedoState : IEquatable<UndoRedoState>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have an unrelated question - does anybody know if that Equals implementation below makes sense? Or is CaretPosition supposed to be ignored?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my understanding, we need to ignore CaretPosition, so new snapshot won't be created when only caret position was changed.

{
public string Text { get; }
public int CaretPosition { get; }
Expand Down