Fix ClassicDesktop Lifetime so that ShutdownRequested event is raised… #7400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 20, 2022 10:36
… even with programatic calls to Shutdown.
danwalmsley
force-pushed
the
fixes/application-shutdown-osx
branch
from
ad2d024
to
aeee9d1
Compare
added 6 commits
January 20, 2022 10:37
jmacato
approved these changes
Jan 20, 2022
danwalmsley
pushed a commit
that referenced
this pull request
Jan 24, 2022
Fix ClassicDesktop Lifetime so that ShutdownRequested event is raised… # Conflicts: # src/Avalonia.Controls/ApiCompatBaseline.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… even with programatic calls to Shutdown.
What does the pull request do?
Many people are confused about the seperate concepts off "Application" shutdown and "Window" closing.
In OSX these are clearly seperate concepts, in Win32.. they also are but 99% of the time.. they are conflated to mean the same thing.
This makes sure that all programmatic and OS triggered "Application" shutdown requests raise the
ShutdownRequestedevent and is cancellable.It adds a method
TryShutdownleaving the existingShutdownmethod to be as it is now... shutdown immediately no matter what.What is the current behavior?
OSX Application Menu Quit menu Item is not cancellable.
What is the updated/expected behavior with this PR?
It is cancellable.
End users can check both ApplicationLifetime.ShutdownRequested event and Window.Closing events to cancel shutdown.
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues
Fixes #7389
Fixes #7393