Fix multiple enumeration of TrayIcon menu items on win32 causing broken tray icon menus #8544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danwalmsley
changed the title
Merged
grokys
approved these changes
Jul 20, 2022
added 2 commits
July 20, 2022 11:58
danwalmsley
force-pushed
the
fixes/trayicon-interaction
branch
from
854ff42
to
961c693
Compare
danwalmsley
pushed a commit
that referenced
this pull request
Jul 20, 2022
Fix multiple enumeration of TrayIcon menu items on win32 causing broken tray icon menus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The menu exporter was using yield, meaning that avalonias logic would be given new menuitem instances every time it enumerated the menus.
This basically meant that many things were broken by the time the menu was displayed.
Most significantly the Parent of the menu item was no longer correct, meaning, no closing when item clicked, and no menu items not highlighting when pointer is hovering over.
Fixes #8312
Fixes #7864