-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Sharing Api #9253
Add Sharing Api #9253
Conversation
8418526
to
0cf76f3
Compare
You can test this PR using the following package version. |
|
@maxkatz6 do we want a separate interface or should the feature be exposed by IStorageProvider? |
|
Yes, but you still can have async API. Operation needs to be initiated on a user gesture. There is no difference if somewhere else it is awaited.
I don't have a strong opinion here. If can be in separated interface. But probably naming should be adjusted to be consistent. Like "IShareProvider" I guess.
It is limiting as only allows to share physically existing file. I am pretty sure these platforms support sharing a stream of data (needs to be double checked). Use case, app generates a 2GB data stream of a videl and user wants to share it to another application. Saving to a physical file and then sharing would be consuming (and problematic on web). |
Stream based sharing API also aligns with our plans to have a fallback solution, when "save file picker" is not available on system (iOS and non-Chrome Browser). |
You can test this PR using the following package version. |
You can test this PR using the following package version. |
You can test this PR using the following package version. |
You can test this PR using the following package version. |
You can test this PR using the following package version. |
You can test this PR using the following package version. |
You can test this PR using the following package version. |
You can test this PR using the following package version. |
You can test this PR using the following package version. |
You can test this PR using the following package version. |
You can test this PR using the following package version. |
I am thinking about API like:
where IDataObject supports text, files and binary inputs (right now in master it's only text and files officially). Also, same API can be done for Windows as well. |
Api now uses DataObjects. I've added helpers to store streams as DataObjects |
You can test this PR using the following package version. |
Closing this PR temporarily due to inactivity. Please ping me if this needs to be reopened. |
What does the pull request do?
Add sharing api and support for the following platforms; Web and Android
The api is accessed using the TopLevel.
What is the current behavior?
What is the updated/expected behavior with this PR?
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues