Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply margin before width/height. #994

Merged
merged 3 commits into from
May 26, 2017
Merged

Conversation

grokys
Copy link
Member

@grokys grokys commented May 25, 2017

Fixes #993.

@kekekeks does this fix the problem you were seeing in #984?

@grokys grokys requested a review from kekekeks May 25, 2017 22:50
@codecov
Copy link

codecov bot commented May 25, 2017

Codecov Report

Merging #994 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #994   +/-   ##
=======================================
  Coverage   55.75%   55.75%           
=======================================
  Files         540      540           
  Lines       20646    20646           
  Branches     2941     2941           
=======================================
  Hits        11512    11512           
  Misses       8250     8250           
  Partials      884      884
Impacted Files Coverage Δ
src/Avalonia.Layout/Layoutable.cs 91.34% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f07960...f5c700a. Read the comment docs.

Copy link
Member

@kekekeks kekekeks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Behavior seems to match WPF now

@kekekeks kekekeks merged commit e822198 into master May 26, 2017
@grokys grokys deleted the fixes/993-margin-width-height branch May 26, 2017 10:54
@grokys grokys added this to the Beta 1 milestone Jan 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Margin gets applied after Width/Height
2 participants