feat: Intellisense displays only the elements related to the current context #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
workgroupengineering
force-pushed
the
features/Intellisense/Type-Affinity
branch
from
a7ef308
to
979ef4b
Compare
workgroupengineering
force-pushed
the
features/Intellisense/Type-Affinity
branch
from
1ac5a45
to
25517d2
Compare
…com/workgroupengineering/AvaloniaVS into features/Intellisense/Type-Affinity
workgroupengineering
force-pushed
the
features/Intellisense/Type-Affinity
branch
3 times, most recently
from
6859c7d
to
8ba08c1
Compare
workgroupengineering
force-pushed
the
features/Intellisense/Type-Affinity
branch
from
8ba08c1
to
fc7b8ef
Compare
# Conflicts: # CompletionEngine/Avalonia.Ide.CompletionEngine.DnlibMetadataProvider/Wrappers.cs
# Conflicts: # tests/CompletionEngineTests/Models.cs
# Conflicts: # CompletionEngine/Avalonia.Ide.CompletionEngine/AssemblyMetadata/Metadata.cs # CompletionEngine/Avalonia.Ide.CompletionEngine/AssemblyMetadata/MetadataConverter.cs # CompletionEngine/Avalonia.Ide.CompletionEngine/Completion/CompletionEngine.cs
# Conflicts: # tests/CompletionEngineTests/AdvancedTests.cs
workgroupengineering
force-pushed
the
features/Intellisense/Type-Affinity
branch
from
d80a464
to
0195139
Compare
workgroupengineering
force-pushed
the
features/Intellisense/Type-Affinity
branch
from
0195139
to
3a8d6f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow Intellisense displays only the elements related to the current context
Current behavior
Expected behavior
After PR AvaloniaUI/Avalonia#13104
How does it work
CompletionEngineget the parent element of the current element, retrieves its type and assigning it toparentTypeparentTypehas a property marked withAvalonia.Metadata.ContentAttribute, assigned its return type toparentType.parentType.ItemsTypeorparentTypeto filter candidate types if they are notnullCurrent issue
If an Item Type has xmlns, xmlns is not entered.Future enhancement
ItemsControl.ItemsPanelAutocompletion ofItemsControlderived objects with the correctItemsType, egListBoxmust proposeListBoxItesand its derivatives.Depends on PR #383 , AvaloniaUI/Avalonia#13104