Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Phased Releases Endpoint #127

Merged
merged 2 commits into from
Dec 17, 2020
Merged

Conversation

Sherlouk
Copy link
Sponsor Contributor

To be merged after #125

Adds support for getting the phased release status.

Will test in my own app (using the fork) to quickly ensure it actually works hitting the real service. Will check in once done 馃憤

@Sherlouk
Copy link
Sponsor Contributor Author

Confirmed working.

Request

provider.request(.appStoreVersionPhasedRelease(ofVersionWithId: "UUID")) { request in
    print(request)
}

Response

success(AppStoreConnect_Swift_SDK.AppStoreVersionPhasedReleaseResponse(data: AppStoreConnect_Swift_SDK.AppStoreVersionPhasedReleaseResponse.Data(id: "UUID", attributes: Optional(AppStoreConnect_Swift_SDK.AppStoreVersionPhasedReleaseResponse.Attributes(currentDayNumber: Optional(1), phasedReleaseState: Optional(AppStoreConnect_Swift_SDK.PhasedReleaseState.active), startDate: Optional(2020-12-14 10:16:45 am +0000), totalPauseDuration: Optional(0))), type: "appStoreVersionPhasedReleases"), links: AppStoreConnect_Swift_SDK.PagedDocumentLinks(first: nil, next: nil, self: https://api.appstoreconnect.apple.com/v1/appStoreVersions/UUID/appStoreVersionPhasedRelease)))

Copy link
Owner

@AvdLee AvdLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've combined both your previous PR and this PR together. Shouldn't be a problem but something to keep an eye on!

@Sherlouk
Copy link
Sponsor Contributor Author

Aye sorry, that was intentional - wanted to test both changes on a single branch!

If they get merged in order shouldn't cause any problems. Sorry about that

@SwiftLeeBot
Copy link
Collaborator

SwiftLeeBot commented Dec 15, 2020

Messages
馃摉

View more details on Bitrise

馃摉 AppStoreConnect-Swift-SDK: Executed 161 tests, with 0 failures (0 unexpected) in 0.468 (1.038) seconds

Generated by 馃毇 Danger Swift against b04dcde

@Sherlouk
Copy link
Sponsor Contributor Author

d'oh
probably need to set the Locale on my date formatter so it's consistent no matter where you run the tests!

@Sherlouk
Copy link
Sponsor Contributor Author

Separated the two PRs, fixed the CI issues on the correct branch. Hopefully should be good 馃憤

@AvdLee AvdLee merged commit c232d6b into AvdLee:master Dec 17, 2020
@Sherlouk Sherlouk deleted the phasedRollout branch December 17, 2020 09:04
@SwiftLeeBot
Copy link
Collaborator

Congratulations! 馃帀 This was released as part of Release 1.3.0 馃殌

Generated by GitBuddy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants