Fix date decoding error #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AvdLee
requested changes
May 4, 2021
| let formatter = DateFormatter() | ||
| formatter.locale = Locale(identifier: "en_US_POSIX") | ||
| formatter.timeZone = TimeZone(secondsFromGMT: 0) | ||
| formatter.calendar = Calendar(identifier: .iso8601) |
There was a problem hiding this comment.
Wouldn't it be enough to set this calendar? Do we really need the timezone and locale setting?
There was a problem hiding this comment.
If we set only the calendar parameter, then locale and timeZone will stay by default (according to the user iOS Settings). And for ISO8601-like DateFormatter it's expected en_US_POSIX locale and GMT timeZone. I think it would be more stable that way.
There was a problem hiding this comment.
Alright, makes sense! Thanks for the detailed explanation 🙂
AppStoreConnect_Swift_SDK.framework: Coverage: 80.82
Generated by 🚫 Danger Swift against 560389c |
AvdLee
approved these changes
May 5, 2021
|
Congratulations! 🎉 This was released as part of Release 1.5.0 🚀 Generated by GitBuddy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was frequently an error
Failed to decode response. This fix should help, at least after a month of observing I didn't see that error appeared again.