Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix List Prerelease Versions and update to match Apple's docs #143

Merged
merged 14 commits into from
May 12, 2021

Conversation

scottlemke
Copy link
Contributor

Summary

Updates the List Prerelease Versions API to fix incorrect parameter names and updated the API so it matches Apple's latest documentation.

Changes in this PR

  • ListPrereleaseVersions.swift was updated with the fixes
  • More granular tests were created in ListPrereleaseVersionsTests.swift to make testing easier to update in the future.

@scottlemke scottlemke requested a review from AvdLee as a code owner May 10, 2021 22:30
Copy link
Owner

@AvdLee AvdLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Good job on the tests 💪

@SwiftLeeBot
Copy link
Collaborator

SwiftLeeBot commented May 11, 2021

Messages
📖

View more details on Bitrise

📖 AppStoreConnect-Swift-SDK: Executed 228 tests, with 0 failures (0 unexpected) in 0.892 (1.683) seconds

AppStoreConnect-Swift-SDKTests.xctest: Coverage: 99.68

File Coverage
ListPrereleaseVersionsTests.swift 100.0%

AppStoreConnect_Swift_SDK.framework: Coverage: 81.33

File Coverage
ListPrereleaseVersions.swift 98.28%

Generated by 🚫 Danger Swift against c384614

@AvdLee
Copy link
Owner

AvdLee commented May 11, 2021

@scottlemke can you update with the base branch?

@scottlemke scottlemke force-pushed the feature/fix-preReleaseVersions branch from a6d1d5f to c384614 Compare May 11, 2021 14:37
@scottlemke
Copy link
Contributor Author

@AvdLee This should be up to date now. Thanks!

@AvdLee AvdLee merged commit 0ba43e7 into AvdLee:master May 12, 2021
@SwiftLeeBot
Copy link
Collaborator

Congratulations! 🎉 This was released as part of Release 1.5.0 🚀

Generated by GitBuddy

@scottlemke scottlemke deleted the feature/fix-preReleaseVersions branch May 14, 2021 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants