Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typo fix for issue 42 #62

Merged
merged 2 commits into from
Jan 3, 2020
Merged

typo fix for issue 42 #62

merged 2 commits into from
Jan 3, 2020

Conversation

heestand-xyz
Copy link
Contributor

Typo fix for APIEndpoint.downloadSalesAndTrendsReports Issue 42

@heestand-xyz heestand-xyz mentioned this pull request Jan 3, 2020
Closed
@ghost
Copy link

ghost commented Jan 3, 2020 •
edited by ghost
Loading

1 Message
📖 View more details on Bitrise

Generated by 🚫 Danger

AvdLee
AvdLee requested changes Jan 3, 2020
View reviewed changes
Copy link
Owner

@AvdLee AvdLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a changelog entry for this?

@heestand-xyz
Copy link
Contributor Author

I updated the changelog. Not sure about the format of the changelog, I added a link to the issue.

AvdLee
AvdLee approved these changes Jan 3, 2020
View reviewed changes
Copy link
Owner

@AvdLee AvdLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is perfect, thanks for your contribution!

@AvdLee AvdLee merged commit 0800af4 into AvdLee:master Jan 3, 2020
@SwiftLeeBot
Copy link
Collaborator

Congratulations! 🎉 This was released as part of Release 1.0.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AvdLee AvdLee AvdLee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@heestand-xyz @SwiftLeeBot @AvdLee