Wrong response type for getAllCertificates call #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This call has a response that corresponds to ProfileDevicesLinkagesResponse, not ProfileResponse. According to the documentation it should be a CertificatesResponse (see https://developer.apple.com/documentation/appstoreconnectapi/list_all_certificates_in_a_profile), but that's not correct either, since the attributes are missing from the certificates in the data array. An alternative option could be to make the attributes optional in certificate and use CertificatesResponse here. For now I propose to abuse ProfileDevicesLinkagesResponse or else create a new response type specifically for this. What do you think?
ristkof
changed the title
|
@ristkof to me it makes the most sense to create a new response for this that matches the outcome. Would you mind doing that instead? FYI; I'm working on fixing CI today, so you don't have to worry about that! And thanks for your contribution 💪 |
AppStoreConnect_Swift_SDK.framework: Coverage: 81.63
Generated by 🚫 Danger Swift against 296e844 |
|
@AvdLee Changed as requested. |
AvdLee
approved these changes
Mar 16, 2020
Repository owner
deleted a comment from
ristkof
Mar 16, 2020
|
Congratulations! 🎉 This was released as part of Release 1.0.1 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This call has a response that corresponds to ProfileDevicesLinkagesResponse, not ProfileResponse. According to the documentation it should be a CertificatesResponse (see https://developer.apple.com/documentation/appstoreconnectapi/list_all_certificates_in_a_profile), but that's not correct either, since the attributes are missing from the certificates in the data array.
An alternative option could be to make the attributes optional in certificate and use CertificatesResponse here.
For now I propose to abuse ProfileDevicesLinkagesResponse or else create a new response type specifically for this.
What do you think?
Screenshot of Charles-dump attached (with some private bits cut out).