Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the parsing of Profile responses #95

Merged
merged 16 commits into from
Apr 30, 2020
Merged

Fix the parsing of Profile responses #95

merged 16 commits into from
Apr 30, 2020

Conversation

orj
Copy link
Contributor

@orj orj commented Apr 17, 2020

There are a number of errors in the parsing of Profiles.

This PR includes the following changes:

Changes of Note

  • Introduces a mechanism for loading fixture data
  • Tests profile parsing using JSON fixtures generated from API requests (but then edited to remove sensitive data)
  • Fixes the models so that ProfilesResponse correctly parses

Misc Changes

  • Improves the APIProvider's error reporting
  • Updates .gitignore and deletes .DS_Store file
  • Fixes main project referencing example project Tests folder

⚠️ Note

This is an API breaking change as I changed the public types, in particular APIProvider.Error.

orj added 13 commits April 15, 2020 18:15
@orj orj requested a review from AvdLee as a code owner April 17, 2020 03:28
AvdLee
AvdLee requested changes Apr 17, 2020
View reviewed changes
Copy link
Owner

@AvdLee AvdLee left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like how you've tested this through! There might come back a few warnings from CI. Would be great if you could fix those 🙂

.gitignore Show resolved Hide resolved
@SwiftLeeBot
Copy link
Collaborator

SwiftLeeBot commented Apr 17, 2020 •
edited
Loading

Messages
📖

View more details on Bitrise
📖 AppStoreConnect-Swift-SDK: Executed 156 tests, with 0 failures (0 unexpected) in 0.863 (1.395) seconds

AppStoreConnect_Swift_SDK.framework: Coverage: 82.5

File Coverage
APIProvider.swift 85.34% ✅
ProfileRelationship.swift 100.0% ✅

Generated by 🚫 Danger Swift against 3604392

@orj orj requested a review from AvdLee April 28, 2020 23:52
AvdLee
AvdLee approved these changes Apr 30, 2020
View reviewed changes
Copy link
Owner

@AvdLee AvdLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@AvdLee AvdLee merged commit 4f27f45 into AvdLee:master Apr 30, 2020
@SwiftLeeBot
Copy link
Collaborator

Congratulations! 🎉 This was released as part of Release 1.1.0 🚀

Generated by GitBuddy

@orj orj deleted the fix/profile-parsing branch May 1, 2020 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AvdLee AvdLee AvdLee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@orj @SwiftLeeBot @AvdLee