Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat : quotes.py #94

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Conversation

akarshghildyal
Copy link
Contributor

Closes: Quote of the Day #71

  • Title : Quote Of The Day
  • Name: Akarsh Ghildyal
  • Idenitfy yourself: SSOC Contributor

Describe the add-ons or changes you've made 📃

Added a Quote of the day program under API Programs.
Give a clear description of what have you added or modifications made
Using zenquotes api, this fetches the quote of the day and displays it.

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

Ran the code locally.

Checklist: ☑️

  • My code follows the Contributing Guidelines & Code of Conduct of this project.
  • This PR does not contain plagiarized content.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • My changes generate no new warnings.

Screenshots 📷

image
image

Copy link

github-actions bot commented Jul 7, 2024

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akarshghildyal LGTM. But attach a working video

@Avdhesh-Varshney Avdhesh-Varshney added the Requested Changes ⚙️ Some changes have been requested in this PR label Jul 7, 2024
@akarshghildyal
Copy link
Contributor Author

Quotes-Jarvis.mp4

@Avdhesh-Varshney uses zenquotes api to fetch for the quote of the day

@Avdhesh-Varshney Avdhesh-Varshney linked an issue Jul 9, 2024 that may be closed by this pull request
@Avdhesh-Varshney Avdhesh-Varshney merged commit ae8095f into Avdhesh-Varshney:main Jul 9, 2024
1 check passed
@Avdhesh-Varshney Avdhesh-Varshney added Intermediate Intermediate level issues/pull requests SSOC These issue/pull request will be considered for SSOC'24 Approved ✔️ This PR is approved by the PR or, Mentors Code Addition ✒️ Integration of new programs and algorithms in Jarvis. Beginner Beginner level issues/pull requests and removed Requested Changes ⚙️ Some changes have been requested in this PR Intermediate Intermediate level issues/pull requests labels Jul 9, 2024
@akarshghildyal akarshghildyal deleted the quote branch July 10, 2024 07:35
@akarshghildyal akarshghildyal restored the quote branch July 10, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved ✔️ This PR is approved by the PR or, Mentors Beginner Beginner level issues/pull requests Code Addition ✒️ Integration of new programs and algorithms in Jarvis. SSOC These issue/pull request will be considered for SSOC'24
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📃: Quote of the Day
2 participants