Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: horoscope in api programs #98

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

akarshghildyal
Copy link
Contributor

Closes: #77

  • Title : Horoscope App
  • Name: Akarsh Ghildyal
  • Idenitfy yourself: SSOC Contributor

Describe the add-ons or changes you've made 📃

Made a horoscope program that asks the user for their sign from the list of 11 signs Aries, Taurus, Gemini, Cancer, Leo, Virgo, Libra, Scorpio, Sagittarius, Capricorn, Aquarius, Pisces and then also has a dropdown to select horoscope for yesterday/today/tomorrow.
Give a clear description of what have you added or modifications made
I have used beautiful soup to scrape the horoscope data from horoscope website and use it in the program.

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

I have tested the code locally on my system.

Checklist: ☑️

Screenshots 📷

Hororscope-Jarvis.mp4

Note to reviewers 📄

I tried to look for free api and/or libraries for this particular task but since I could not find anything reliable I found an article on horoscope project and utilized the same technique here.
There was this python library - pyaztro 0.3 which I initially thought could be used but it is outdated hence I scraped the idea.

Copy link

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

@Avdhesh-Varshney Avdhesh-Varshney merged commit 3846afe into Avdhesh-Varshney:main Jul 12, 2024
1 check passed
@Avdhesh-Varshney Avdhesh-Varshney added enhancement 🧑‍💻 New feature or request Intermediate Intermediate level issues/pull requests SSOC These issue/pull request will be considered for SSOC'24 Approved ✔️ This PR is approved by the PR or, Mentors Code Addition ✒️ Integration of new programs and algorithms in Jarvis. labels Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved ✔️ This PR is approved by the PR or, Mentors Code Addition ✒️ Integration of new programs and algorithms in Jarvis. enhancement 🧑‍💻 New feature or request Intermediate Intermediate level issues/pull requests SSOC These issue/pull request will be considered for SSOC'24
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📃: Daily Horoscope Display
2 participants