Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solved the Issue for exposed Auth Details #160

Merged
merged 1 commit into from
Jun 29, 2024

Conversation

ROKUMATE
Copy link
Contributor

Closes: Issue #114 and rectified the pull request #159

  • Solved the issue for Exposed authInfo and made it in .env file :
  • Name: Rohit Kumawat (ROKUMATE)
  • GSSOC Contributer

Describe the add-ons or changes you've made 📃

Created a .env File in which add this code
QUOTES_API_KEY=<THE_REQUIRED_AUTH_INFO>
The Auth Info U provided was 4fe303f4bamshb97ef5b1dd575e0p1ccc51jsnd9644d3c587b

and changed the declaration of it inside of the code as well

Checklist: ☑️

  • My code follows the code style of this project.
  • My code follows the Contributing Guidelines & Code of Conduct of this project.
  • This PR does not contain plagiarized content.
  • I have performed a self-review of my own code.
  • My changes generate no new warnings.

Copy link

vercel bot commented Jun 28, 2024

@ROKUMATE is attempting to deploy a commit to the avdheshvarshney's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

Copy link

vercel bot commented Jun 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chanakya ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 29, 2024 7:24am

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ROKUMATE PR Approved 🎉

@Avdhesh-Varshney Avdhesh-Varshney merged commit 9364f23 into Avdhesh-Varshney:main Jun 29, 2024
4 checks passed
@Avdhesh-Varshney Avdhesh-Varshney added bug 🐛 Something isn't working gssoc These issue/pull request will be considered for GSSOC'24 level1 Beginner level issues/pull requests Approved ✔️ This PR is approved by the PR or, Mentors labels Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved ✔️ This PR is approved by the PR or, Mentors bug 🐛 Something isn't working gssoc These issue/pull request will be considered for GSSOC'24 level1 Beginner level issues/pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛: Authorization token exposed , sol : authorize token via ENV
2 participants