Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefetcher object is not deleted in ScriptEnvironment destructor #50

Closed
chainikdn opened this issue Oct 26, 2014 · 3 comments
Closed

Prefetcher object is not deleted in ScriptEnvironment destructor #50

chainikdn opened this issue Oct 26, 2014 · 3 comments

Comments

@chainikdn
Copy link

It's created in Prefetcher::Create() and then lives forever, which lead to:

  • threads are not ended
  • filter objects are not deleted

Fixed by adding if (prefetcher) delete prefetcher; to ScriptEnvironment::~ScriptEnvironment()
@chainikdn
Copy link
Author

It works for x64 build but crashes x32 version.
Have no idea why Prefetcher object is cleared correctly in x32 and NOT cleared in x64 but just delete it is not a right solution.

@pylorak pylorak mentioned this issue Mar 9, 2015
Closed
@pylorak
Copy link
Member

pylorak commented Mar 9, 2015

Problem only seems to exist as a filter in 64-bit ffdshow.
http://forum.doom9.org/showthread.php?p=1712683#post1712683

@pylorak
Copy link
Member

pylorak commented Mar 15, 2015

Seems to be an issue with ffdshow. Avs+ cannot completely prevent leaking with such misbehaving hosts, but commit 422aae8 at least avoid leaking VFBs which are the largest objects.

@pylorak pylorak closed this as completed Mar 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pylorak @chainikdn