AVX-51277: Do not set bucket_name for config backup in Azure. #1968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the controller we have a bound validator that ensures that the `bucket_name` parameter is non-empty. When we send a request to backup configuration for Azure, we use a set of different parameters and we do not set `bucket_name`. This causes validation to fail for Azure.
avx-rchung
reviewed
Mar 6, 2024
avx-rchung
reviewed
Mar 6, 2024
avx-rchung
approved these changes
Mar 6, 2024
dnardo
added a commit
that referenced
this pull request
Mar 6, 2024
AVX-51277: Do not set bucket_name for config backup in Azure.
avx-rchung
added a commit
that referenced
this pull request
Mar 6, 2024
…onnect-7.1 Merge pull request #1968 from AviatrixSystems/AVX-51277
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the controller we have a bound validator that ensures that the
bucket_nameparameter is non-empty. When we send a request to backup configuration for Azure, we use a set of different parameters and we do not setbucket_name. This causes validation to fail for Azure.