Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to build as a meson subproject and make cmoka an optionnal dependency #24

Merged
merged 2 commits into from
Mar 3, 2020

Conversation

thiblahute
Copy link
Contributor

This adds a meson option to allow disabling tests.

@thiblahute thiblahute force-pushed the meson_enhancements branch 3 times, most recently from 27c7af6 to bf9b2b7 Compare February 15, 2020 13:10
@andrew-elder
Copy link

I know nothing about meson, although changes look to be ok to me. Can some else please provide some additional feedback?

@thiblahute
Copy link
Contributor Author

You can find additional information about subprojects here btw.

This allows us to build libavtp as part of the GStreamer build if it is not available on the system.

@thiblahute
Copy link
Contributor Author

Also not that since meson 0.47.0 there is a new option type called features which would allow us to make cmoka optional dependency handling nicer but I didn't want to bump the dep (and 0.47 requires python3>=3.5 which is not present on the CI system you use).

@aguedes
Copy link
Collaborator

aguedes commented Feb 18, 2020

Hi @thiblahute, thanks for the PR. I'll review it by EOW.

meson.build Show resolved Hide resolved
meson.build Outdated Show resolved Hide resolved
meson.build Outdated Show resolved Hide resolved
And make cmoka an optional dependency
@aguedes
Copy link
Collaborator

aguedes commented Mar 3, 2020

Hi @thiblahute, thanks for this updated version. I'm merging it now. Regarding the 'features' option type introduced in meson 0.47.0, yes, it would make the cmocka dependency handling nicer indeed. If you're up to it, feel free to update our meson and python versions in CI and refactor the dependency handling. I'd be glad to merge those patches! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants