Add RVF support #35
Merged
Add RVF support #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks for the PR, @adrianf0!
Looks really good, just a few comments =D
|
@edersondisouza Thank you for the review. I applied all your suggestions except the one regarding formatting. Please check my comment on it. |
Copied from linux kernel (added Macros alignment). Helps to keep code formatting. Signed-off-by: Adrian Fiergolski <adrian.fiergolski@fastree3d.com>
Signed-off-by: Adrian Fiergolski <adrian.fiergolski@fastree3d.com>
This patch adds support for AVTP Raw Video Format (RVF) specified in chapter 12 of the IEEE 1722-2016 spec. RVF is based on AVTP Stream PDU, so it reuses `struct avtp_stream_pdu` defined in avtp.h. However, as the Raw header has two 32-bit fields more than that struct, it also introduces a "struct avtp_rvf_payload" that is used to access the fields defined on the "avtp_payload" field. RVF API is exposed via "avtp_rvf.h" header, including raw specific bits. Signed-off-by: Adrian Fiergolski <adrian.fiergolski@fastree3d.com>
Adds unit tests "test-rvf.c" that implements several RVF test cases. The tests should cover all APIs defined in "avtp_rvf.h". Signed-off-by: Adrian Fiergolski <adrian.fiergolski@fastree3d.com>
|
lgtm! |
vcgomes
approved these changes
Nov 1, 2021
|
@edersondisouza : I have added support to Gstreamer (link). Feel free to take a look. |
Great! I'll take a look in the next few days =D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR request adds RVF support (#33).